Fix a couple of places where user should be able to control things #37

alanruttenberg · 2017-02-01T04:31:38Z

In quicklisp-abcl, quicklisp directory was defaulting to (user-homedir-pathname). Make this customizable by using variable asdf::quicklisp-parent-dir
in abcl-contrib.lisp there was defparameter verbose, which should be defvar, and which was ignored in two places where it shouldn't have been.

In quicklisp-abcl, quicklisp directory was defaulting to (user-homedir-pathname). Make this customizable by using variable asdf::*quicklisp-parent-dir* in abcl-contrib.lisp there was defparameter *verbose*, which should be defvar, and which was ignored in two places where it shouldn't have been.

In QUICKLISP-ABCL, the parent of the Quicklisp directory was defaulting to (USER-HOMEDIR-PATHNAME). We make this customizable by declaring a special variable QUICKLISP-ASDF:*QUICKLISP-PARENT-DIR*. Originally part of <#37>.

…vities Originally part of <#37>.

easye · 2017-02-01T11:14:26Z

Rejected as presented:

Should have been two separate commits, one for core ABCL and one for QUICKLISP-ABCL
Don't pollute ASDF package with ABCL-specific symbols (define and use a QUICKLISP-ABCL package instead).
Rename SYSTEM:VERBOSE to SYSTEM:ABCL-CONTRIB-VERBOSE to hopefully clarify its meaning.

Functionality split into two patches that have been merged

5044bc7

6cc94a5

Thanks for the patches!

In QUICKLISP-ABCL, the parent of the Quicklisp directory was defaulting to (USER-HOMEDIR-PATHNAME). We make this customizable by declaring a special variable QUICKLISP-ASDF:*QUICKLISP-PARENT-DIR*. Originally part of <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn@14969 1c010e3e-69d0-11dd-93a8-456734b0d56f

…vities Originally part of <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn@14970 1c010e3e-69d0-11dd-93a8-456734b0d56f

As Alan noted, the configuration option has to be present *before* Quicklisp loads, so we place it in CL-USER while removing the unnecessary QUICKLISP-ABCL package. c.f. <8f140c0> . originally part of <#37> .

Normalize logging output to a Lisp comment prefix (#\;) with a single tag that identifies the "subsystem" emitting the diagnostic. ABCL-ASDF:*MAVEN-VERBOSE* SYS:*ABCL-CONTRIB-VERBOSE* have been removed; use CL:*LOAD-VERBOSE* to control them. ASDF::*VERBOSE-OUT* and QUICKLISP-CLIENT::*QUICKLOAD-VERBOSE* cannot be easily modified while keeping in-sync with upstream, but they both seem to respect setting CL:*LOAD-VERBOSE* to nil to muffle output. EXT::*WARN-ON-REDEFINITION* signals conditions rather than just emitting error messages, so it has not been touched as theoretically some compiler tooling may be somehow be depending on its SIGNAL behavior. As such, once an implementation that signals the same warnings as EXT::*WARN-ON-REDEFINITION* based on CL:*COMPILE-VERBOSE* setting should be maintained during a deprecation phase. ------------------------------------------------------------------------ # From <6cc94a5> ## Alan Ruttenberg Really this should just respect load-verbose. If you really want to fix this properly, do that. There are a proliferation of settings one has to know about if one wants ABCL to shut up while starting up, and any beginner will have a hell of a time accomplishing this. There ought to be a single variable that indicates you don't want these messages. - *load-verbose* - system::*verbose* - asdf::*verbose-out* - abcl-asdf::*maven-verbose - quicklisp-client::*quickload-verbose* - ext::*warn-on-redefinition* ## Mark Evenson Using CL:LOAD-VERBOSE to unify the control of all this logging behavior for ABCL is an excellent way forward here. This wouldn't help with quicklisp-client::quickload-verbose (not our code). An alternative would be to have some sort of "categorical logging system" (ala log4j) which would allow one to selectively enable classes of logging output ("show me all diagnostic from loading ABCL-CONTRIB"), but a basic boolean predicate here, unified into the standardized mechanism would go a long ways. ------------------------------------------------------------------------ Originated with <#37>.

As Alan noted, the configuration option has to be present *before* Quicklisp loads, so we place it in CL-USER while removing the unnecessary QUICKLISP-ABCL package. c.f. <armedbear/abcl@8f140c0> . originally part of <armedbear/abcl#37> . git-svn-id: http://abcl.org/svn@14972 1c010e3e-69d0-11dd-93a8-456734b0d56f

Normalize logging output to a Lisp comment prefix (#\;) with a single tag that identifies the "subsystem" emitting the diagnostic. ABCL-ASDF:*MAVEN-VERBOSE* SYS:*ABCL-CONTRIB-VERBOSE* have been removed; use CL:*LOAD-VERBOSE* to control them. ASDF::*VERBOSE-OUT* and QUICKLISP-CLIENT::*QUICKLOAD-VERBOSE* cannot be easily modified while keeping in-sync with upstream, but they both seem to respect setting CL:*LOAD-VERBOSE* to nil to muffle output. EXT::*WARN-ON-REDEFINITION* signals conditions rather than just emitting error messages, so it has not been touched as theoretically some compiler tooling may be somehow be depending on its SIGNAL behavior. As such, once an implementation that signals the same warnings as EXT::*WARN-ON-REDEFINITION* based on CL:*COMPILE-VERBOSE* setting should be maintained during a deprecation phase. ------------------------------------------------------------------------ # From <armedbear/abcl@6cc94a5> ## Alan Ruttenberg Really this should just respect load-verbose. If you really want to fix this properly, do that. There are a proliferation of settings one has to know about if one wants ABCL to shut up while starting up, and any beginner will have a hell of a time accomplishing this. There ought to be a single variable that indicates you don't want these messages. - *load-verbose* - system::*verbose* - asdf::*verbose-out* - abcl-asdf::*maven-verbose - quicklisp-client::*quickload-verbose* - ext::*warn-on-redefinition* ## Mark Evenson Using CL:LOAD-VERBOSE to unify the control of all this logging behavior for ABCL is an excellent way forward here. This wouldn't help with quicklisp-client::quickload-verbose (not our code). An alternative would be to have some sort of "categorical logging system" (ala log4j) which would allow one to selectively enable classes of logging output ("show me all diagnostic from loading ABCL-CONTRIB"), but a basic boolean predicate here, unified into the standardized mechanism would go a long ways. ------------------------------------------------------------------------ Originated with <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn@14974 1c010e3e-69d0-11dd-93a8-456734b0d56f

In QUICKLISP-ABCL, the parent of the Quicklisp directory was defaulting to (USER-HOMEDIR-PATHNAME). We make this customizable by declaring a special variable QUICKLISP-ASDF:*QUICKLISP-PARENT-DIR*. Originally part of <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn/trunk/abcl@14969 1c010e3e-69d0-11dd-93a8-456734b0d56f

…vities Originally part of <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn/trunk/abcl@14970 1c010e3e-69d0-11dd-93a8-456734b0d56f

As Alan noted, the configuration option has to be present *before* Quicklisp loads, so we place it in CL-USER while removing the unnecessary QUICKLISP-ABCL package. c.f. <armedbear/abcl@8f140c0> . originally part of <armedbear/abcl#37> . git-svn-id: http://abcl.org/svn/trunk/abcl@14972 1c010e3e-69d0-11dd-93a8-456734b0d56f

Normalize logging output to a Lisp comment prefix (#\;) with a single tag that identifies the "subsystem" emitting the diagnostic. ABCL-ASDF:*MAVEN-VERBOSE* SYS:*ABCL-CONTRIB-VERBOSE* have been removed; use CL:*LOAD-VERBOSE* to control them. ASDF::*VERBOSE-OUT* and QUICKLISP-CLIENT::*QUICKLOAD-VERBOSE* cannot be easily modified while keeping in-sync with upstream, but they both seem to respect setting CL:*LOAD-VERBOSE* to nil to muffle output. EXT::*WARN-ON-REDEFINITION* signals conditions rather than just emitting error messages, so it has not been touched as theoretically some compiler tooling may be somehow be depending on its SIGNAL behavior. As such, once an implementation that signals the same warnings as EXT::*WARN-ON-REDEFINITION* based on CL:*COMPILE-VERBOSE* setting should be maintained during a deprecation phase. ------------------------------------------------------------------------ # From <armedbear/abcl@6cc94a5> ## Alan Ruttenberg Really this should just respect load-verbose. If you really want to fix this properly, do that. There are a proliferation of settings one has to know about if one wants ABCL to shut up while starting up, and any beginner will have a hell of a time accomplishing this. There ought to be a single variable that indicates you don't want these messages. - *load-verbose* - system::*verbose* - asdf::*verbose-out* - abcl-asdf::*maven-verbose - quicklisp-client::*quickload-verbose* - ext::*warn-on-redefinition* ## Mark Evenson Using CL:LOAD-VERBOSE to unify the control of all this logging behavior for ABCL is an excellent way forward here. This wouldn't help with quicklisp-client::quickload-verbose (not our code). An alternative would be to have some sort of "categorical logging system" (ala log4j) which would allow one to selectively enable classes of logging output ("show me all diagnostic from loading ABCL-CONTRIB"), but a basic boolean predicate here, unified into the standardized mechanism would go a long ways. ------------------------------------------------------------------------ Originated with <armedbear/abcl#37>. git-svn-id: http://abcl.org/svn/trunk/abcl@14974 1c010e3e-69d0-11dd-93a8-456734b0d56f

alanruttenberg force-pushed the myway-2017-02-01-pull-37 branch from da8bdee to 72bc159 Compare February 1, 2017 05:34

alanruttenberg force-pushed the myway-2017-02-01-pull-37 branch from 72bc159 to a04505a Compare February 1, 2017 06:11

easye pushed a commit that referenced this pull request Feb 1, 2017

SYSTEM:*ABCL-CONTRIB-VERBOSE* controls verbosity of ABCL-CONTRIB acti…

6cc94a5

…vities Originally part of <#37>.

easye closed this Feb 1, 2017

alanruttenberg deleted the myway-2017-02-01-pull-37 branch February 3, 2017 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix a couple of places where user should be able to control things #37

Fix a couple of places where user should be able to control things #37

alanruttenberg commented Feb 1, 2017

easye commented Feb 1, 2017

Fix a couple of places where user should be able to control things #37

Fix a couple of places where user should be able to control things #37

Conversation

alanruttenberg commented Feb 1, 2017

easye commented Feb 1, 2017