fix(expose): override public service port #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request needs to be changed to match the format: See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions Some common examples are: |
cristhian-castaneda
changed the title
This was referenced Jan 28, 2021
Pull Request Test Coverage Report for Build 518525925
💛 - Coveralls |
dogonthehorizon
approved these changes
Jan 28, 2021
cristhian-castaneda
added a commit
that referenced
this pull request
Feb 18, 2021
* fix(build): no push dev image to scan.connect.redhat.com (#184) * fix(timeout): avoid revalidation when patching Spinnaker Status. (#192) * fix(timeout): avoid revalidation when patching Spinnaker Status. * fix(timeout): add unit test. * fix(timeout): add unit test. * chore(cve): fix for CVE-2020-13757 (#193) * feat(validator/aws): add aws account validator. (#195) * feat(validator/aws): add aws account validator. * feat(validator/aws): solve PR comments. * chore(halyard): Updated halyard version (#197) * chore(halyard): Updated halyard version (#200) * fix(validation): validate primary account for kubernetes provider. (#209) * fix(expose): override public service port (#210) * fix(expose): override service port if 'expose.service.overrides.{service}.publicPort' is defined. * fix(expose): avoid to override patches. * fix(expose): cleanup code. * fix(expose): add unit test. * fix(expose): add unit test. * fix(expose): add unit test. * chore(halyard): Updated halyard version (#213) Co-authored-by: Jossue <jossue@gmail.com>
cristhian-castaneda
added a commit
that referenced
this pull request
May 6, 2021
* fix(build): no push dev image to scan.connect.redhat.com (#184) * fix(timeout): avoid revalidation when patching Spinnaker Status. (#192) * fix(timeout): avoid revalidation when patching Spinnaker Status. * fix(timeout): add unit test. * fix(timeout): add unit test. * chore(cve): fix for CVE-2020-13757 (#193) * feat(validator/aws): add aws account validator. (#195) * feat(validator/aws): add aws account validator. * feat(validator/aws): solve PR comments. * chore(halyard): Updated halyard version (#197) * chore(halyard): Updated halyard version (#200) * fix(validation): validate primary account for kubernetes provider. (#209) * fix(expose): override public service port (#210) * fix(expose): override service port if 'expose.service.overrides.{service}.publicPort' is defined. * fix(expose): avoid to override patches. * fix(expose): cleanup code. * fix(expose): add unit test. * fix(expose): add unit test. * fix(expose): add unit test. * chore(halyard): Updated halyard version (#213) * feat(health-check): increase timeout and validate ready replicas for status. (#219) * feat(health-check): increase timeout and validate ready replicas for status. * feat(health-check): fix unit tests. * fix(build): set up Go in github action. * doc(fix): add Plugins section to README (#220) * doc(fix): add Plugins section to README add plugins section and point to Armory docs * finish sentence Co-authored-by: Cristhian Castaneda <ccastanedarivera@gmail.com> * feat(cloudfoundry/validation): Add a CloudFoundry validation for each… (#222) * feat(cloudfoundry/validation): Add a CloudFoundry validation for each account. * feat(cloudfoundry/validation): Adding unit tests for CF Service. * chore(halyard): Updated halyard version (#232) Co-authored-by: Jossue <jossue@gmail.com> Co-authored-by: aimeeu <aimeeu.opensource@gmail.com> Co-authored-by: JB <jorgebee65@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Operator to override the port if
expose.service.overrides.{service}.publicPortis defined.Fixes #204
related PR #208