Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health-check): increase timeout and validate ready replicas for status. #219

Merged

Conversation

cristhian-castaneda
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 659759722

  • 10 of 13 (76.92%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 36.532%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/spinnakerservice/status.go 10 13 76.92%
Totals Coverage Status
Change from base Build 576671671: 0.08%
Covered Lines: 2128
Relevant Lines: 5825

💛 - Coveralls

@cristhian-castaneda cristhian-castaneda merged commit 3d409c8 into master Mar 17, 2021
@cristhian-castaneda cristhian-castaneda deleted the fix/increase-timeout-and-validate-ready-replicas branch March 17, 2021 05:05
@cristhian-castaneda
Copy link
Contributor Author

@mergify back-port release-1.2.x

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2021

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Hey, I reacted but my real name is @Mergifyio

@cristhian-castaneda
Copy link
Contributor Author

@Mergifyio backport release-1.2.x

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2021

Command backport release-1.2.x: failure

No backport have been created
GitHub App like Mergify are not allowed to create pull request where .github/workflows is changed.

cristhian-castaneda added a commit that referenced this pull request Mar 17, 2021
…status. (#219)

* feat(health-check): increase timeout and validate ready replicas for status.

* feat(health-check): fix unit tests.

* fix(build): set up Go in github action.

(cherry picked from commit 3d409c8)
cristhian-castaneda added a commit that referenced this pull request Mar 17, 2021
…status. (#219) (#221)

* feat(health-check): increase timeout and validate ready replicas for status.

* feat(health-check): fix unit tests.

* fix(build): set up Go in github action.

(cherry picked from commit 3d409c8)
cristhian-castaneda added a commit that referenced this pull request May 6, 2021
* fix(build): no push dev image to scan.connect.redhat.com (#184)

* fix(timeout): avoid revalidation when patching Spinnaker Status. (#192)

* fix(timeout): avoid revalidation when patching Spinnaker Status.

* fix(timeout): add unit test.

* fix(timeout): add unit test.

* chore(cve): fix for CVE-2020-13757 (#193)

* feat(validator/aws): add aws account validator. (#195)

* feat(validator/aws): add aws account validator.

* feat(validator/aws): solve PR comments.

* chore(halyard): Updated halyard version (#197)

* chore(halyard): Updated halyard version (#200)

* fix(validation): validate primary account for kubernetes provider. (#209)

* fix(expose): override public service port (#210)

* fix(expose): override service port if 'expose.service.overrides.{service}.publicPort' is defined.

* fix(expose): avoid to override patches.

* fix(expose): cleanup code.

* fix(expose): add unit test.

* fix(expose): add unit test.

* fix(expose): add unit test.

* chore(halyard): Updated halyard version (#213)

* feat(health-check): increase timeout and validate ready replicas for status. (#219)

* feat(health-check): increase timeout and validate ready replicas for status.

* feat(health-check): fix unit tests.

* fix(build): set up Go in github action.

* doc(fix): add Plugins section to README (#220)

* doc(fix): add Plugins section to README

add plugins section and point to Armory docs

* finish sentence

Co-authored-by: Cristhian Castaneda <ccastanedarivera@gmail.com>

* feat(cloudfoundry/validation): Add a CloudFoundry validation for each… (#222)

* feat(cloudfoundry/validation): Add a CloudFoundry validation for each account.

* feat(cloudfoundry/validation): Adding unit tests for CF Service.

* chore(halyard): Updated halyard version (#232)

Co-authored-by: Jossue <jossue@gmail.com>
Co-authored-by: aimeeu <aimeeu.opensource@gmail.com>
Co-authored-by: JB <jorgebee65@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants