Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(health-check): increase timeout and validate ready replicas for status. (#219) #221

Merged
merged 1 commit into from
Mar 17, 2021
Merged

feat(health-check): increase timeout and validate ready replicas for status. (#219) #221

merged 1 commit into from
Mar 17, 2021

Conversation

cristhian-castaneda
Copy link
Contributor

No description provided.

@cristhian-castaneda
feat(health-check): increase timeout and validate ready replicas for …
d705c9b 
…status. (#219)

* feat(health-check): increase timeout and validate ready replicas for status.

* feat(health-check): fix unit tests.

* fix(build): set up Go in github action.

(cherry picked from commit 3d409c8)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 661589437

  • 10 of 13 (76.92%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 36.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/spinnakerservice/status.go 10 13 76.92%
Totals Coverage Status
Change from base Build 578948740: 0.08%
Covered Lines: 2128
Relevant Lines: 5825
💛 - Coveralls

@cristhian-castaneda cristhian-castaneda merged commit b97be22 into release-1.2.x Mar 17, 2021
@cristhian-castaneda cristhian-castaneda deleted the backport-status-check branch March 17, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogonthehorizon dogonthehorizon dogonthehorizon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristhian-castaneda @coveralls @dogonthehorizon