Fix cpu_count() for incomplete PATH var on Windows and improve error handling #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzBrueckner
added
the
Release Notes: Fixes
MoritzBrueckner
force-pushed
the
fix-cpu-count
branch
from
a9c35e3
to
1430e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344 (comment).
Even though
C:\Windows\System32should be part of the PATH environment variable by default (source), there might be cases where this entry is missing andutils.cpu_count()could fail becausewmic.execould not be found.This PR also improves the error handling in that function by also using the logical CPU count as a last resort for FileNotFoundErrors and by showing some information about what went wrong.