Various export fixes for subsurface scattering #2450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sssWidth
variable in the shader which is one of the issue mentioned here: Just few bug pictures #2136_SSS
flag wasn't set. I'm not completely happy with the solution, but I'm not yet confident enough with the material exporter code to be able to refactor the code in a way that prevents the dependency/order issues that can happen. It might be a good idea to first check all the requirements of a material, store them temporary with the material and only then create the shaders.@luboslenco Do you remember why the material ID is handled via a uniform whose value is defined during export (see this and this)? Is it for context variants or to be able to merge similar shaders for less context switches?