Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #491 segfault in RdKafka\TopicPartition::__construct() #492

Merged
merged 2 commits into from Nov 22, 2021

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Nov 20, 2021

Drop nullable attribute, default value should be enough.

If you want to keep it, you need an additional arg to store null, and test it (probably don't worth it)


    if (zend_parse_parameters(ZEND_NUM_ARGS(), "sl|l!", &topic, &topic_len, &partition, &offset, &is_null) == FAILURE) {
        ...
    }
    if (is_null) {
    ....
    }

@andypost
Copy link
Contributor

@remicollet Thank you a lot! it passed all arches https://gitlab.alpinelinux.org/alpine/aports/-/pipelines/100300

@arnaud-lb arnaud-lb merged commit 43d0c18 into arnaud-lb:6.x Nov 22, 2021
@arnaud-lb
Copy link
Owner

Thanks @remicollet !

@remicollet remicollet deleted the issue-491 branch November 23, 2021 08:38
@andypost
Copy link
Contributor

please create RC2 release

@arnaud-lb
Copy link
Owner

I will release it later today :)

@arnaud-lb
Copy link
Owner

https://pecl.php.net/package/rdkafka/6.0.0RC2

@andypost
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants