Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of w=1.0 for VI, for consistency with MCMC #32

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

joelnmdyer
Copy link
Collaborator

Fixes #18

@joelnmdyer joelnmdyer requested a review from arnauqb July 12, 2023 18:38
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0bf0e1) 79.30% compared to head (1cd3bf6) 79.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files          17       17           
  Lines         686      686           
=======================================
  Hits          544      544           
  Misses        142      142           
Impacted Files Coverage Δ
blackbirds/infer/vi.py 85.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arnauqb arnauqb merged commit 6121a0d into main Jul 12, 2023
3 checks passed
@arnauqb arnauqb deleted the set_w branch July 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make default value of w consistent across VI and MCMC methods
2 participants