Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ast compilation #34

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Refactor ast compilation #34

merged 2 commits into from
Nov 27, 2020

Conversation

arnodel
Copy link
Owner

@arnodel arnodel commented Nov 27, 2020

ast -> ir compilation is refactored into the astcomp package, to remove the dependency ast -> ir. Now we have:

ast <- astcomp -> ir

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #34 (6f2d298) into master (2a16464) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   89.59%   89.00%   -0.60%     
==========================================
  Files          70       70              
  Lines        5893     5303     -590     
==========================================
- Hits         5280     4720     -560     
+ Misses        419      390      -29     
+ Partials      194      193       -1     
Impacted Files Coverage Δ
runtime/lib.go 75.42% <100.00%> (-2.97%) ⬇️
runtime/cont.go 16.66% <0.00%> (-13.34%) ⬇️
runtime/error.go 44.44% <0.00%> (-9.13%) ⬇️
lib/base/dofile.go 42.85% <0.00%> (-7.15%) ⬇️
lib/golib/golib.go 51.51% <0.00%> (-5.82%) ⬇️
luatesting/linechecker.go 72.41% <0.00%> (-4.73%) ⬇️
runtime/numconv.go 61.29% <0.00%> (-3.42%) ⬇️
lib/iolib/file.go 74.28% <0.00%> (-3.37%) ⬇️
lib/base/ipairs.go 63.63% <0.00%> (-3.04%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a16464...6f2d298. Read the comment docs.

@arnodel arnodel merged commit e04c5ef into master Nov 27, 2020
@arnodel arnodel deleted the refactor-ast-compilation branch November 27, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant