fix: persist focus when switching tabs #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the callbacks related to persisting focus when switching tabs, switched from a timeout based approach to cancel the callbacks to a method that looks for change in focus. The timeout based method was not working on Chrome and Firefox in Windows. The new approach still ensures that only the most recent math-field element will have a `visibilitychange` callback associated with it.
mgreminger
added a commit
to mgreminger/EngineeringPaper.xyz
that referenced
this pull request
Feb 24, 2024
Need to use a fork of mathlive with this fix until arnog/mathlive#2301 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the callbacks related to persisting focus when switching tabs, this pull request changes from a timeout based approach to cancel the callbacks to a method that looks for change in focus. The timeout based method was not working on Chrome and Firefox in Windows. The new approach still ensures that only the most recent math-field element will have a
visibilitychangecallback associated with it.