return bigints from ratio ops only when bigint operand

arohner · Jun 16, 2010 · a1a25da · a1a25da
1 parent d97599c
commit a1a25da
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/src/jvm/clojure/lang/LispReader.java b/src/jvm/clojure/lang/LispReader.java
@@ -360,7 +360,8 @@ else if((n = m.group(7)) != null)
 	m = ratioPat.matcher(s);
 	if(m.matches())
 		{
-		return Numbers.divide(new BigInteger(m.group(1)), new BigInteger(m.group(2)));
+		return Numbers.divide(Numbers.reduceBigInteger(new BigInteger(m.group(1))),
+		                      Numbers.reduceBigInteger((new BigInteger(m.group(2)))));
 		}
 	return null;
 }

diff --git a/src/jvm/clojure/lang/Numbers.java b/src/jvm/clojure/lang/Numbers.java
@@ -607,42 +607,54 @@ public boolean isNeg(Number x){
 		return r.numerator.signum() < 0;
 	}
 
+	static Number normalizeRet(Number ret, Number x, Number y){
+		if(ret instanceof BigInteger && !(x instanceof BigInteger || y instanceof BigInteger))
+			{
+			return reduceBigInteger((BigInteger) ret);
+			}
+		return ret;
+	}
+
 	final public Number add(Number x, Number y){
 		Ratio rx = toRatio(x);
 		Ratio ry = toRatio(y);
-		return divide(ry.numerator.multiply(rx.denominator)
+		Number ret = divide(ry.numerator.multiply(rx.denominator)
 				.add(rx.numerator.multiply(ry.denominator))
 				, ry.denominator.multiply(rx.denominator));
+		return normalizeRet(ret, x, y);
 	}
 
 	final public Number multiply(Number x, Number y){
 		Ratio rx = toRatio(x);
 		Ratio ry = toRatio(y);
-		return Numbers.divide(ry.numerator.multiply(rx.numerator)
+		Number ret = Numbers.divide(ry.numerator.multiply(rx.numerator)
 				, ry.denominator.multiply(rx.denominator));
+		return normalizeRet(ret, x, y);
 	}
 
 	public Number divide(Number x, Number y){
 		Ratio rx = toRatio(x);
 		Ratio ry = toRatio(y);
-		return Numbers.divide(ry.denominator.multiply(rx.numerator)
+		Number ret = Numbers.divide(ry.denominator.multiply(rx.numerator)
 				, ry.numerator.multiply(rx.denominator));
+		return normalizeRet(ret, x, y);
 	}
 
 	public Number quotient(Number x, Number y){
 		Ratio rx = toRatio(x);
 		Ratio ry = toRatio(y);
 		BigInteger q = rx.numerator.multiply(ry.denominator).divide(
 				rx.denominator.multiply(ry.numerator));
-		return q;
+		return normalizeRet(q, x, y);
 	}
 
 	public Number remainder(Number x, Number y){
 		Ratio rx = toRatio(x);
 		Ratio ry = toRatio(y);
 		BigInteger q = rx.numerator.multiply(ry.denominator).divide(
 				rx.denominator.multiply(ry.numerator));
-		return Numbers.minus(x, Numbers.multiply(q, y));
+		Number ret = Numbers.minus(x, Numbers.multiply(q, y));
+		return normalizeRet(ret, x, y);
 	}
 
 	public boolean equiv(Number x, Number y){
@@ -1012,11 +1024,11 @@ public Number shiftRight(Number x, int n){
 static Ops ops(Object x){
 	Class xc = x.getClass();
 
-	if(xc == Long.class)
+	if(xc == Integer.class)
 		return LONG_OPS;
 	else if(xc == Double.class)
 		return DOUBLE_OPS;
-	else if(xc == Integer.class)
+	else if(xc == Long.class)
 		return LONG_OPS;
 	else if(xc == Float.class)
 		return DOUBLE_OPS;