Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to another GH follow script. #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Feb 29, 2016

Button now generated using: http://www.buildbuttons.com/GitHub/FollowButton

This solves #20, but doesn't look as nice so might need some style tweaking which isn't as easy as the styling is contained within a separate HTML page in an <iframe> with it's own styling.

The current PR contains the small button:

screenshot

I've tried the big button as well, but that looks even worse:
screenshot

Button now generated using: http://www.buildbuttons.com/GitHub/FollowButton

This solves aron-bordin#20, but doesn't look as nice so might need some style tweaking which isn't as easy as the styling is contained within a separate HTML page in an `<iframe>` with it's own styling.

The current PR contains the small button:

![screenshot](http://snag.gy/IXLXH.jpg)

I've tried the big button as well, but that looks even worse:
![screenshot](http://snag.gy/KbOKu.jpg)
@ccjjmartin
Copy link

It looks like this was fixed upstream and we no longer need to switch implementation of follow buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants