Fix various GCC 13 warnings and errors #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to improvements in system and/or compiler header cleanliness,
where previously ParseTools.{cpp,h}'s headers have included <cstdint>
as a byproduct, this no longer occurs. Hence:
- Ordinary unsigned is appropriate for the int2str() variable anyway;
- Get CHRPOS from BedtoolsTypes.h instead of typedeffing it ourselves;
- ParseTools.cpp's isHeaderLine() does use uint32_t, so include <cstdint>
from the .cpp file for good measure.
Assignment operators should not be virtual (avoids "Record::operator=
was hidden" warnings). List member initialisers in the same order in
which they are declared (avoids "_testLastQueryRec will be initialized
after _runToDbEnd" warnings).
This was referenced Oct 25, 2023
|
This is fantastic! Thanks as always for your expert help, @jmarshall ! |
|
@arq5x could you please cut a new release so we can remove all the patches from our repos? |
|
Yes. It will take me a few days to a week or so because of deadlines, but I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1056 et al, on recent platforms ParseTools.cpp/.h fail to compile due to
uint32_tnot being declared. The obvious fix is to add#include <cstdint>but we can tidy things up a bit by fixing this differently. This PR fixes that build failure and also fixes several warnings encountered with GCC 13:Due to improvements in system and/or compiler header cleanliness, where previously ParseTools.{cpp,h}'s headers have included
<cstdint>as a byproduct, this no longer occurs. Hence:<cstdint>from the .cpp file for good measure.Other warnings:
Fixes #1056. Closes #1045 and closes #1066.