Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow installing with react 17 #789

Closed
wants to merge 1 commit into from
Closed

Allow installing with react 17 #789

wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Contributor

Description

Allow installing with react 17

Motivation and Context

To avoid warning about react 17

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[x] I have added tests covering my changes
[ ] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@anajavi
Copy link
Contributor

anajavi commented May 26, 2021

There is already an PR for this: #764

@yadomi yadomi mentioned this pull request Oct 27, 2022
Merged
@arqex
Copy link
Owner

arqex commented Oct 27, 2022 •
edited
Loading

We've added support for react 18 already at #838

@alexander-schranz alexander-schranz deleted the patch-1 branch October 27, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-schranz @anajavi @arqex