Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow react 17 as peerDependency #764

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Allow react 17 as peerDependency #764

merged 1 commit into from
Sep 2, 2021

Conversation

anajavi
Copy link
Contributor

@anajavi anajavi commented Dec 18, 2020

Adds react 17 as peerDependency to prevent warnings.

Description

Allows react 17 as peerDependency
fixes #792
fixes #774

Motivation and Context

react-datetime works with react 17.

Testing against react 17 is blocked by enzyme-adapter-17, which still in development: enzymejs/enzyme#2430

Checklist

[X] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[X] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@zackdotcomputer
Copy link

Resolves #774

@tamal-appsbee
Copy link

Please merge it.

@dmathijs
Copy link

Why does this remain open?

@zackdotcomputer
Copy link

@arqex hasn't been very active on Github since last fall and IDK if anyone else has merge rights on the repo.

@layneanderson layneanderson merged commit b0a4460 into arqex:master Sep 2, 2021
@anajavi anajavi deleted the react-17-peer branch September 2, 2021 18:11
@arqex
Copy link
Owner

arqex commented Sep 2, 2021

Thanks @anajavi for sending the change and @layneanderson for merging it! I've just published the v3.1.0 with react 17 as peer dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make react-datetime compatible with React 17.0.2 Please update peer deps
6 participants