Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomcat 7 managed NPE #31

Closed
lordofthejars opened this issue Aug 14, 2015 · 1 comment
Closed

Tomcat 7 managed NPE #31

lordofthejars opened this issue Aug 14, 2015 · 1 comment
Assignees

Comments

@lordofthejars
Copy link
Member

If you set catalinaHome in arquillian.xml to your tomcat installation, you need to set catalinaBase as well. If not a NPE is thrown since in TomcatManagedContainer is executed next line, and CATALINA_BASE is not set.

final String absoluteCatalinaBasePath = new File(CATALINA_BASE).getAbsolutePath();

I think that we could modify this so in case catalinaHome property is set in arquillian.xml but system property not set to CATALINA_BASE, then CATALINA_BASE could be directly the value set in catalinaHome arquillian property.

@rhusar rhusar self-assigned this May 27, 2024
@rhusar
Copy link
Collaborator

rhusar commented May 27, 2024

Thanks for the report @lordofthejars, upon triage this has been fixed a while ago simply as you suggested

            if (CATALINA_BASE == null) {
                CATALINA_BASE = CATALINA_HOME;
            }

Closing as resolved.

@rhusar rhusar closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants