Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register arquillian-testenricher-cdi as CDI extension to obtain BeanManager in a portable way. #19

Closed
wants to merge 5 commits into from
Closed

Register arquillian-testenricher-cdi as CDI extension to obtain BeanManager in a portable way. #19

wants to merge 5 commits into from

Conversation

htfv
Copy link
Contributor

@htfv htfv commented Sep 8, 2011

No description provided.

@aslakknutsen
Copy link
Member

We should try JNDI before using the CDIExtension. In a AppServer, the AppServer is responsible for setting up the JNDI based on the caller and get the correct BeanManager for the Module in a multi Module deployment. If not, we might be fetching the wrong BeanManager.

@htfv
Copy link
Contributor Author

htfv commented Sep 15, 2011

Oh... I think I broke something, now there are 5 commits instead of 2. If fixed lookup order in be96f5e.

@aslakknutsen
Copy link
Member

When you want to update your topic branch to a new version of master, use rebase instead of merge/pull

git checkout master
git pull upstream master
git checkout my_topic
git rebase master
git push origin -f my_topic

That will rewrite my_topic branch on top of master instead of merging in master at the point where my_topic is. That keeps the timeline in order. You have now rewritten the timeline of my_topic so you'll need to use -f (force) to push it to github

@htfv
Copy link
Contributor Author

htfv commented Sep 15, 2011

Sorry, I plain suck in git. Created new pull request #21.

@htfv htfv closed this Sep 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants