New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces jakarta servlet protocol module #246
Conversation
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Fixes #248 This PR and #250 are duplicated efforts. Since this one came first, I closed mine and we can go with this one. Meanwhile, I have based my Tomcat adapter work on this PR - arquillian/arquillian-container-tomcat#87 |
@starksm64 thanks for this new module. Can you give reviewers edit rights to this branch. This would avoid roundtrips for updating this PR against latest master. |
I have sent you an invite with write access |
@bartoszmajsak, can you take a look at merging this and getting another arq core release out please? |
Sure, I will make that happen tomorrow. Sorry for keeping this one in limbo - got some personal issues to take care of last few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work. Much appreciated. I see that only the following files are jakarta-ee
specific:
ServletContextRegistrar.java
ServletContextResourceProvider.java
AbstractServerBase.java
ServletTestRunner.java
the rest rely on Arquillian and ShrinkWrap APIs. This makes me wonder if making some common module would be beneficial here. Not necessary as part of this PR and I can take care of it. WDYT @starksm64 @manovotn?
@bartoszmajsak I am not against it just not sure it's worth it. Any further development/changes are likely to take place in this new module. Might as well have it all in one place. I know it is duplicating, but any changes to those files would eventually lead us to move them here anyway. Is there so many of them? Also, note that the tests in this new module (in this PR) are not executed ATM because they require JDK 11. We should IMO setup travis to run that with 11. |
Right, it is just a question of whether it is worth the time. There certainly is a significant amount of redundancy between the two servlet protocols though. |
I'm working on it. |
Added JDK 11 build in #255 |
This updates the servlet protocol to support the Jakarta EE 9 jakarta.* package based Servlet 5 APIs