Introduce new protocol/servlet module for Jakarta #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, added a commit to bump Travis to use JDK 11, let's see what that happens. Meanwhile, I will use this PR as basis for arquillian/arquillian-container-tomcat#86 and report back once I have a working setup. Any comments here are welcome of course. I admit I am not familiar with how Arq. does servlet protocol so I kind of did a semi-blind copy-paste and hoped for the best :-D |
|
Humm did we both miss #246? |
|
Uff, looks like we did. I mean, no surprise, it doesn't have an issue an not even a mention of either of us :-/ |
|
Let's go with Scott's version, they are pretty similar but his is more polished already. I've just rebased my Tomcat adapter work on that, it was a rather easy change. So closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248
Adds new module that copies over things from
protocols/servletand usesjakartadependency instead ofjavax. Also updates Jetty test dep to 11 which runs on EE 9. However, this changes makes it so that I can only run it with JDK 11 so we will need to change the CI execution (which I can add to this PR if we agree on that).Second commit prunes the new module and removes the notion of version 2.5 and 3 support because (unless I am mistaken) EE 9 means servlet v4 and you cannot really run anything older due to the namespace change.