Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split configuration between implementations #43

Closed
aslakknutsen opened this issue Nov 23, 2014 · 1 comment · Fixed by #139
Closed

Split configuration between implementations #43

aslakknutsen opened this issue Nov 23, 2014 · 1 comment · Fixed by #139
Assignees
@aslakknutsen
Labels
enhancement

Comments

@aslakknutsen
Copy link
Member

When we have more then 'docker server' as an implementation we need to split the configuration.

Probably in :

  • Core
  • Docker
  • X

Core currently has options like:

  • autoStartContainers

Docker has:

  • serverVersion
  • serverUri
  • dockerContainers
  • dockerContainersFile
  • dockerRegistry

Assuming Cube is Docker focused, dockerContainers, dockerContainersFile and dockerRegistry might be reusable configuration options for Cube Core.

Define Docker images in Core, Docker Server info in Docker and extra Kuberetes features around the Docker images in it's own config
@aslakknutsen aslakknutsen added this to the 1.0.0.Alpha2 milestone Nov 23, 2014
@aslakknutsen aslakknutsen self-assigned this Nov 23, 2014
@aslakknutsen
Copy link
Member Author

Is required by #41 and most likely becomes just a part of it. But how it needs to be done needs some discussion.

@lordofthejars lordofthejars mentioned this issue Dec 9, 2014
Closed
@lordofthejars lordofthejars removed this from the 1.0.0.Alpha5 milestone Apr 2, 2015
aslakknutsen added a commit to aslakknutsen/arquillian-cube that referenced this issue May 20, 2015
@aslakknutsen
Seperate Docker impl into Core and Docker
69f6a1a 
Cube Core can be reused between multiple Cube impls,
e.g. Docker and OpenShift.

* Split CubeConfiguration into CubeConfiguration and CubeDockerConfiguration.
  Only moved connectionMode to CubeConfiguration.

  CubeDocker is mapped to old qualifier: docker
  Cube is mapped to qualifer: cube

* Docker has new package name: org.arquillian.cube.docker

fixes arquillian#43
fixes arquillian#40
@aslakknutsen aslakknutsen mentioned this issue May 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslakknutsen aslakknutsen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Seperate Docker impl into Core and Docker aslakknutsen/arquillian-cube
2 participants
@aslakknutsen @lordofthejars