Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets localhost URI when unix socket used #88

Closed
lordofthejars opened this issue Feb 1, 2015 · 3 comments
Closed

Sets localhost URI when unix socket used #88

lordofthejars opened this issue Feb 1, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@lordofthejars
Copy link
Member

Sets localhost URI when unix socket used. Currently the IP of the docker server is got from configuration file. If unix socket is used then we need to set to localhost.

@aslakknutsen
Copy link
Member

If you read back dockerClientConfig.getUri after calling DockerCmdExecFactoryImpl.init it will update that Uri to be the sanitized version of the unix socket uri, meaning localhost:80. The port number makes no sense, but..

Perhaps just as easy to just do if schema == unix:: as it would be to rely on a internal impl detail.. ;)

@lordofthejars
Copy link
Member Author

my idea was that something like if URI protocol is unix:// then localhost

@aslakknutsen
Copy link
Member

yea, just as well

lordofthejars added a commit that referenced this issue Feb 1, 2015
Resolves issues #77 and #88 and adds ss command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants