Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ContainerConfig exposedPorts if no HostConfig boundPorts found #210

Merged
merged 1 commit into from Nov 18, 2015

Conversation

aslakknutsen
Copy link
Member

In this scenario boundPort is set to -1.

fixes #208

I updated the 'ping' polling option to take the -1 boundPort into account. Not sure if there are other places we need to handle this as well?

@lordofthejars
Copy link
Member

Maybe when you use @HostPort in ContainerObject

where we can decide if we let user to receive a -1 or throw an exception.

@aslakknutsen
Copy link
Member Author

lordofthejars added a commit that referenced this pull request Nov 18, 2015
Return ContainerConfig exposedPorts if no HostConfig boundPorts found
@lordofthejars lordofthejars merged commit 948068f into arquillian:master Nov 18, 2015
@lordofthejars lordofthejars added this to the 1.0.0.Alpha8 milestone Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PollingAwaitStrategy throws NPE when no portBinding is provided
2 participants