Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ClassCastException in AutomaticResolutionStartParser #214

Conversation

robertpanzer
Copy link
Contributor

At least when building on Win7 the links are returned as an ArrayList instead of a Set as expected.
Just expecting a Collection makes the test pass for me on Win.

@lordofthejars
Copy link
Member

yes it is fixed locally, but I am not sure why this is happening since a A set is created https://github.com/arquillian/arquillian-cube/blob/master/docker/docker/src/main/java/org/arquillian/cube/docker/impl/docker/compose/ContainerBuilder.java#L290

@robertpanzer
Copy link
Contributor Author

This code is actually never called when I debug it.
The ArrayList that I see is created directly by the Yaml parser.

(Maybe because the file is treated as a Cube file and not as a docker-compose yaml?)

@lordofthejars
Copy link
Member

Right, are you using universe?

@robertpanzer
Copy link
Contributor Author

I'm building arquillian-cube, not an own project.

@robertpanzer
Copy link
Contributor Author

The test case that is failing on my machine is org.arquillian.cube.docker.impl.client.CubeSuiteLifecycleControllerTest#shouldCreateAndStartAutoContainersWhenNoAutoStartIsProvided()

@lordofthejars
Copy link
Member

ok, no worries now it is fixed, but yes probably the YAML is the one who is causing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants