Added CountLatch to use it for StatsCmd. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordofthejars
requested changes
Nov 9, 2016
| try { | ||
| statsCmd.exec(statslogs).awaitCompletion(); | ||
| StatsLogsResultCallback statscallback = statsCmd.exec(statslogs); | ||
| countDownLatch.await(3, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Can you change this to 5 seconds, I am thinking on remote docker host.
There was a problem hiding this comment.
Shouldn't we make it configurable then?
There was a problem hiding this comment.
Wouldn't it be possible to use CompletableFuture instead?
There was a problem hiding this comment.
@bartoszmajsak What do you mean by configurable? We have added countdownlatch only not to go in deadlock.
There was a problem hiding this comment.
I mean we hardcoded to 5s instead of 3s based on some assumptions. What if my machine is even slower so I might need a bit longer timeout?
lordofthejars
approved these changes
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Only tomcat container is stopping other thread execution even if call
onComplete()event in StatsLogsResultCallback when you have added recorder dependency in your class path.Changes proposed in this pull request:
Fixes: #519