Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#988): creating container if it has destroyed state #995

Merged
merged 3 commits into from Feb 23, 2018
Merged

fix(#988): creating container if it has destroyed state #995

merged 3 commits into from Feb 23, 2018

Conversation

dipak-pawar
Copy link
Contributor

Changes proposed in this pull request:

  • Allow DockerCube to create docker container if it's destroyed

Fixes #988

bartoszmajsak
bartoszmajsak approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipak-pawar. Did you try steps leading to this issue reported in #998?

@dipak-pawar
Copy link
Contributor Author

Did you try steps leading to this issue reported in #998?

I haven't tried. But I believe this is what we are testing in unit test which I added as a part of this PR

@dipak-pawar dipak-pawar merged commit 5b010fc into arquillian:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak bartoszmajsak approved these changes

@lordofthejars lordofthejars lordofthejars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dipak-pawar @bartoszmajsak @lordofthejars