Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate xhr.response values in wrapper callback #137

Merged
merged 1 commit into from
Sep 29, 2015
Merged

Propagate xhr.response values in wrapper callback #137

merged 1 commit into from
Sep 29, 2015

Commits on Sep 25, 2015

  1. Propagate xhr.response values in callback

    When the xhr wrapper is created the response property is copied but it isn't updated in the callback, which leads to the property values' being out of sync. Some frameworks (e.g. Angular) will use the xhr.response over xhr.responseText if it is present, which means that simply using a guardAjax in a Graphene test will cause all subsequent xhr calls to return invalid data. In my case (Firefox 38, Angular 1.4.4, Graphene 2.0.3.Final) all $http calls would return "" once a guardAjax was executed, despite valid data being shown in Firefox's request log.
    Vulcannis committed Sep 25, 2015
    Configuration menu
    Copy the full SHA
    c89e37d View commit details
    Browse the repository at this point in the history