ARQGRA-345: GrapheneElement can not be used as @Root - fixed #90
Conversation
* GrapheneElement can be now used as field type for Page Fragment @root * It required couple of refactorins: I had to extract interface from GrapheneElement, because proxy which is created for it needs that interface in the list of interfaces which it should implement * I had to rename the implementation to GrapheneElementImpl * GrapheneElement is wrapped element, I had to add to the WrapperEnricher conditional code which would take into account the GrapheneElement - it is ugly bit imo only only solution right now
|
An Innovative Testing Platform for the JVM » arquillian-graphene #249 SUCCESS |
| Object wrapper; | ||
| try { | ||
| wrapper = createWrapper(grapheneContext, field.getType(), WebElementUtils.findElementLazily(rootBy, localSearchContext)); | ||
| Class<?> type = field.getType().equals(GrapheneElement.class) ? GrapheneElementImpl.class : field.getType(); |
There was a problem hiding this comment.
These are the ugly parts. IMHO it can be refactored with DI somehow. Personally I would leave that to the time of resolving:
ARQGRA-302 - page fragments injectable by interfaces
There was a problem hiding this comment.
Yes, it comes to idea of @ImplementedBy - this method should allow us to use single interface for instantiating classes by their types, e.g. it's API:
Instantiator#instantiate(Class<?> clazz);
We use custom approach in several API classes, because their respective implementations are implemented in Impl module, e.g.:
It would be beneficial to use single interface which will allow to mark an interface with @ImplementedBy which refers to the implementation type name or the class (which is more refactoring-prone).
GrapheneElement, because proxy which is created for it needs that
interface in the list of interfaces which it should implement
WrapperEnricher conditional code which would take into account the
GrapheneElement - it is ugly bit imo only only solution right now