-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create request package #18
Conversation
//(...) | ||
RequestID request.ID | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why recommend the Request ID be passed by struct if you added the GetRequestIDFromContext? This could be the standard way to manipulate Request IDs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you are encoding the response, you don't have the service's context, only the service response. Could be used in "BaseEndpointResponse", but this project don't have a standard API base response (yet)
a0e7ed5
to
2039330
Compare
This is a initial package to put and get a string (Request ID) in context. The request ID always will be created when the method WithRequestID is used.
2039330
to
05b429f
Compare
PR updated |
Rename files; Create "request.IsEmpty"; Returns empty string when request is empty, in method String()
@rjfonseca updated |
This is a initial package to put and get a string (Request ID) in context.
The request ID always will be created when the method WithRequestID is
used.