Create request package #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-reis
approved these changes
Dec 9, 2019
rjfonseca
reviewed
Dec 9, 2019
| //(...) | ||
| RequestID request.ID | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Why recommend the Request ID be passed by struct if you added the GetRequestIDFromContext? This could be the standard way to manipulate Request IDs.
There was a problem hiding this comment.
When you are encoding the response, you don't have the service's context, only the service response. Could be used in "BaseEndpointResponse", but this project don't have a standard API base response (yet)
victormn
force-pushed
the
feature/requestid
branch
from
a0e7ed5
to
2039330
Compare
This is a initial package to put and get a string (Request ID) in context. The request ID always will be created when the method WithRequestID is used.
victormn
force-pushed
the
feature/requestid
branch
from
2039330
to
05b429f
Compare
|
PR updated |
rjfonseca
reviewed
Dec 9, 2019
Rename files; Create "request.IsEmpty"; Returns empty string when request is empty, in method String()
|
@rjfonseca updated |
rjfonseca
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a initial package to put and get a string (Request ID) in context.
The request ID always will be created when the method WithRequestID is
used.