Refactors impl/ folder #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The impl/ folder was using an old pattern, where every implementation would fall into the same package. The major problem with this approach is that it forces the clients to import way more dependencies than it is really needed. This commit refactors the implementations into specific folders, while also mantaining the deprecated versions for compatibility. Fixes #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impl/ folder was using an old pattern, where every implementation would
fall into the same package. The major problem with this approach is that it
forces the clients to import way more dependencies than it is really needed.
This commit refactors the implementations into specific folders, while also
mantaining the deprecated versions for compatibility.
Fixes #11