[Pipeline Sink] Pubsub implementation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcosbmf
commented
Sep 28, 2022
marcosbmf
commented
- Adds implementation for a PubSub pipeline sink.
marcosbmf
requested review from
rjfonseca,
andremissaglia,
victormn and
rilder-almeida
victormn
approved these changes
Sep 28, 2022
| // MustNew creates a new pubsub sink or panics if fails | ||
| func MustNew(topicGateway TopicGateway) (sink *Sink, closeFunc func()) { | ||
| op := errors.Op("pubsubsink.MustNew") | ||
| fmt.Println(topicGateway == nil) |
There was a problem hiding this comment.
I think this Println was forgotten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.