Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Calendar.RemoveEvent method #90

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

zachmann
Copy link
Contributor

The RemoveEvent method I added in #88 was (I assume accidentally) dropped in #84
As it seems there were some problems merging #66 and it then dropped the method.
Could we please re-add it.

@arran4
Copy link
Owner

arran4 commented Apr 11, 2024

It doesn't look like it was #88 but I can see that it was in:
https://github.com/arran4/golang-ical/pull/84/files#diff-7d5b515acd9bc43799b68025f4daf330c82648bf6317557565f1b01465e79272L434

Sorry about that. Did you look to see if there were others? -- Not required for PR just means I don't need to double check

Copy link
Owner

@arran4 arran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arran4 arran4 merged commit 9fab3f0 into arran4:master Apr 11, 2024
13 checks passed
@arran4
Copy link
Owner

arran4 commented Apr 11, 2024

@zachmann https://github.com/arran4/golang-ical/releases/tag/v0.2.8

@zachmann
Copy link
Contributor Author

It doesn't look like it was #88 but I can see that it was in: https://github.com/arran4/golang-ical/pull/84/files#diff-7d5b515acd9bc43799b68025f4daf330c82648bf6317557565f1b01465e79272L434

You're right, I linked the wrong number.

Sorry about that. Did you look to see if there were others? -- Not required for PR just means I don't need to double check

No I didn't checked; I just discovered that "my" function was gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants