OS X Installer Fixes #1629
Merged
OS X Installer Fixes #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix how the user is obtained (http://apple.stackexchange.com/questions/144159/how-can-i-determine-the-invoking-user-in-an-apple-installer-postinstall-script) * Do brew install/tap commands only if the packages are not found * This was we avoid errors from double installation
…links This issue probably originated around 3.3 where libaf*.dylib / libaf*.major.dylib were not being treated as symlinks but were full versions of the library on their own. This was due to CMake copying symlinks as the files they point to rather than symlinks.
mlloreda
reviewed
Oct 20, 2016
| @@ -14,13 +14,16 @@ if [ ! -f $brew ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| user=$(ps aux | grep console | grep -v 'grep\|root' | cut -d' ' -f1 | head -n1) | |||
| #user=$(ps aux | grep console | grep -v 'grep\|root' | cut -d' ' -f1 | head -n1) | |||
| user=$(stat -f '%Su' $HOME) | |||
umar456
reviewed
Oct 25, 2016
| @@ -261,10 +296,10 @@ IF(BUILD_GRAPHICS) | |||
| PKG_BUILD( PKG_NAME ForgeLibrary | |||
| DEPENDS OSX_INSTALL_SETUP_FORGE_LIB | |||
| TARGETS forge_lib_package | |||
| INSTALL_LOCATION /usr/local/ | |||
| INSTALL_LOCATION /usr/local/lib | |||
There was a problem hiding this comment.
This doesn't look right. Was it really installing the libraries in the /usr/local directory? I don't see a change in the PKG_BUILD function that is associated with this change.
There was a problem hiding this comment.
@shehzan10 clarified that this is indeed correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share/Forge/*being installed both in/usr/local/*and /usr/local/share/Forge/*` (the former was wrong).postinstallscript not working due to not having +x enabled.postinstallscript.[skip arrayfire ci]
These fixes have been retroactively been applied to the ArrayFire-v3.4.1_OSX.pkg installer available on the arrayfire.com/download site.