Add env var to save generated kernels src to tmp dir #2404
Conversation
Add an env var option in order to save generated JIT kernels.
Add an env var option in order to save generated JIT kernels.
There was a problem hiding this comment.
This looks good. I want to make the environment variable interface slightly more flexible for future changes. Also could you add documentation for this variable in https://github.com/arrayfire/arrayfire/blob/master/docs/pages/configuring_arrayfire_environment.md?
src/backend/common/util.hpp
Outdated
| @@ -15,3 +15,7 @@ | |||
| #pragma once | |||
|
|
|||
| std::string getEnvVar(const std::string &key); | |||
|
|
|||
| // Dump the kernel sources only if the environment variable is defined | |||
| static const char* saveJitKernelsEnvVarName = "AF_DUMP_JIT_KERNELS_DIR"; | |||
There was a problem hiding this comment.
Can you rename this to AF_JIT_KERNEL_TRACE?
It accepts 1 and writes it to stdout or "directory:..." and it will create a file for each kernel. In the future I will be creating a graphviz images so I want this to be slightly more flexible.
There was a problem hiding this comment.
Renamed. Now accepts stdout/stderr.
src/backend/common/util.hpp
Outdated
| @@ -15,3 +15,7 @@ | |||
| #pragma once | |||
|
|
|||
| std::string getEnvVar(const std::string &key); | |||
|
|
|||
| // Dump the kernel sources only if the environment variable is defined | |||
| static const char* saveJitKernelsEnvVarName = "AF_DUMP_JIT_KERNELS_DIR"; | |||
There was a problem hiding this comment.
I prefer to let you officially publish that option in the doc when the specs will be totally stable.
|
Tks Umar. @pavanky and others : please review : it s today not possible to inspect/look at jit kernel sources without that change. |
|
Only one review is required. The branch has a couple of conflicts that I am going to address in a bit. |
* Use AF_JIT_KERNEL_TRACE environment variable to save kernel to file or display on stdout or stderr (cherry picked from commit 4bdaa9e)
* Use AF_JIT_KERNEL_TRACE environment variable to save kernel to file or display on stdout or stderr (cherry picked from commit 4bdaa9e)
* Use AF_JIT_KERNEL_TRACE environment variable to save kernel to file or display on stdout or stderr (cherry picked from commit 4bdaa9e)
Add an env var option to save generated JIT kernels src to a folder.
#2310