Improve convolution batch support documentation #2639
Conversation
|
Posting this image here for reference on how the equations for convolve2 were rendered (at least on my macbook): |
|
Hmm. That doesn't look very readable. |
There was a problem hiding this comment.
I have some feedback generally about grammar and how the rendered docs look.
Also, can we add the separators between each convolution group in the dox file? So it's easier to distinguish which section is which in the dox (by separators, I mean the usual comment line, like below)
//=====================================================================
I think the equations are:
P.S. Since AF is a math library we can assume safely that basic set notation is known to users. |
9prady9
force-pushed
the
conv_docs_fix
branch
from
fcc2423
to
8544861
Compare
9prady9
requested review from
umar456 and
mark-poscablo
and removed request for
syurkevi
9prady9
force-pushed
the
conv_docs_fix
branch
from
8544861
to
b975da6
Compare
|
Updated documentation, I think it is more clear and precise (without ambiguity) than before now. |
9prady9
force-pushed
the
conv_docs_fix
branch
2 times, most recently
from
ed7e573
to
27ef2ab
Compare
Also includes the following changes * Fix reference warnings in ml header * Improve conv docs in general
9prady9
force-pushed
the
conv_docs_fix
branch
from
27ef2ab
to
d41da4f
Compare
There was a problem hiding this comment.
Approving. Thanks for all the work @9prady9, appreciate it.
Fixes #2625
Merge arrayfire/assets#11 before merging this PR