Fix indexing error and add support for CUDA 11.1 #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array based indexing caused segfaults sometimes when the index object was not immidiately consumed by the indexing operations. This PR fixes this by retaining the index array on the copy constructor
9prady9
approved these changes
Oct 5, 2020
|
Thanks again for this @umar456. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with indexing where uncommon usage of the indexing object caused a segfault.
Description
When copying indexing objects, the reference count was not incremented. this caused a segfault. This becomes an issue when you are directly using the indexing object.
Added support for CUDA 11 and compute capability 8.6(GTX 3090)
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented