Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SKIP_AUTH_URI parameter description is incorrect. #61

Open
66li opened this issue Feb 1, 2021 · 2 comments
Open

The SKIP_AUTH_URI parameter description is incorrect. #61

66li opened this issue Feb 1, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@66li
Copy link

66li commented Feb 1, 2021

The images version I am using gcr.io/arrikto/kubeflow/oidc-authservice:28c59ef
When I use Comma-separated list, I get the following error

ERR_TOO_MANY_REDIRECTS

The correct description is as follows

SKIP_AUTH_URI Space separated list of URIs like "/info /health" to bypass auth. Default empty

@66li 66li added the bug Something isn't working label Feb 1, 2021
@edwardzjl
Copy link
Contributor

And the param name in the document is SKIP_AUTH_URIS which is also incorrect.

@edwardzjl
Copy link
Contributor

Ok I find the problem. I'm using oidc-authservice with kubeflow (from kubeflow/manifests repo), which is not the latest version of oidc-authservice

So in version gcr.io/arrikto/kubeflow/oidc-authservice:28c59ef, the param was defined as SKIP_AUTH_URI not SKIP_AUTH_URLS, and is whitespace-separated not comma-separated.

In the latest version gcr.io/arrikto/kubeflow/oidc-authservice:e236439, the param was defined as SKIP_AUTH_URLS and is comma-separated, (I added a test in settings_test.go to verify it) but will get an ERR_TOO_MANY_REDIRECTS error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants