This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Deprecate @higherkind & @extension for ListK #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nomisRev
commented
Dec 19, 2020
•
nomisRev
commented
- Eq (EqK, EqK2)
- Order
- Hash
- Show
- Semigroup (SemigroupK)
- Monoid (MonoidK)
- Functor
- Apply
- Applicative
- Monad
- Traverse
- Foldable
- Crosswalk
- MonadLogic
- MonadPlus
- Alternative
- Align
- MonadFilter
- MonadCombine
- Monoidal
- Semigroupal
- Semialign
- Unalign
- Zip
- Unzip
nomisRev
commented
Dec 19, 2020
| ): List<K> = | ||
| mapN(b, c, d, e, f, g, h, i, j, unit) { b, c, d, e, f, g, h, i, j, _ -> map(b, c, d, e, f, g, h, i, j) } | ||
|
|
||
| inline fun <B, C, D, E, F, G, H, I, J, K, L> mapN( |
There was a problem hiding this comment.
These signatures are conflicting with the ones defined for Nullable.kt :( Any suggestions?
https://github.com/arrow-kt/arrow-core/blob/master/arrow-core-data/src/main/kotlin/arrow/core/Nullable.kt#L28
There was a problem hiding this comment.
This will need 2 deprecation cycles.
- Deprecate top-level
mapNin favor onobject Nullable, addmapNforListonListK, addmapNforMaponMapK, ... - Remove top-level
mapNfornullable, deprecatemapNforListandMapin favor of top-levelmapNfunction
raulraja
reviewed
Jan 4, 2021
| fun <A> List<A>.hashWithSalt(HA: Hash<A>, arg1: Int): Int = | ||
| _hashWithSalt(HA, arg1) | ||
|
|
||
| object List { |
There was a problem hiding this comment.
nit, this object may need deprecation too if someone has ever projected other functions on it beside using ours
raulraja
reviewed
Jan 4, 2021
arrow-core/src/main/kotlin/arrow/core/extensions/list/monad/ListKMonad.kt
Outdated
Show resolved
Hide resolved
raulraja
reviewed
Jan 4, 2021
| internal val semigroupal_singleton: ListKSemigroupal = object : | ||
| arrow.core.extensions.ListKSemigroupal {} | ||
|
|
||
| object List { |
raulraja
reviewed
Jan 4, 2021
| @@ -108,7 +101,6 @@ interface ListKApply : Apply<ForListK> { | |||
| fix().map2(fb, f) | |||
| } | |||
|
|
|||
| @extension | |||
raulraja
approved these changes
Jan 4, 2021
…stKMonad.kt Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
franciscodr
approved these changes
Jan 6, 2021
|
Great job, @nomisRev! |
i-walker
reviewed
Jan 6, 2021
| * cached extension | ||
| */ | ||
| @PublishedApi() | ||
| internal val monad_singleton: ListKMonad = object : arrow.core.extensions.ListKMonad {} |
There was a problem hiding this comment.
Does this needs to be deprecated, too?
There was a problem hiding this comment.
No, it's internal to Arrow so no need to deprecate it. It's only used in the same file.
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.