Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Move nullable mapN to Nullable, and deprecate top-level ones #278

Merged
merged 1 commit into from Dec 21, 2020

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Dec 21, 2020

Currently we cannot define mapN for List or Map since they don't have companion object in the Std, and they conflict with the A? nullable version of mapN.

To solve this we need to move the top-level nullable extension functions to object Nullable, this allows us to write extensions for nullable in a way they don't pollute the namespace for all other types.

See discussion: #276 (comment) for more details.

cc\ original author @tapegram

@nomisRev nomisRev requested a review from a team December 21, 2020 09:34
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev 😄

@raulraja raulraja merged commit cb56dcf into master Dec 21, 2020
@raulraja raulraja deleted the sv-deprecate-top-level-nullable-mapN branch December 21, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants