Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Fix apply order of product to be consistent with other methods #71

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Fix apply order of product to be consistent with other methods #71

merged 1 commit into from
Mar 18, 2020

Conversation

1Jajen1
Copy link
Member

@1Jajen1 1Jajen1 commented Mar 17, 2020

Fixes a few ordering problems that I missed in earlier passes.

@1Jajen1 1Jajen1 merged commit 0b29165 into master Mar 18, 2020
@1Jajen1 1Jajen1 deleted the jo-fix-product-order branch March 18, 2020 02:30
@1Jajen1
Copy link
Member Author

1Jajen1 commented Mar 18, 2020

Thanks @pakoito
At some point this needs better testing. All the product-*, tupledN, mapN methods that is, however I can't think of a good way to check ordering because making it part of Apply would be wrong as that alone does not imply any ordering. The fact that it is left-to-right in arrow is merely convention (a good one, but not a requirement)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pakoito pakoito pakoito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1Jajen1 @pakoito