-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Disabling parallel execution temporarily could be good to pinpoint the issue first. We disable it for a while and keep an eye on that flakiness. The aim would be to reduce the risk of falling into false positives that end up driving a big potentially non needed refactor. |
Thanks @nomisRev 🙌 I think we should follow the Kotest improvements. For instance, 4.1.1 was released. However, I cannot find the release notes (not found in CHANGELOG neither GitHub releases). Simon, you could include a new variable version for Kotest here to speed up those updates from this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rachelcarmena @aballano @danimontoya @raulraja I think we can fix the It seems this was already flaky before the |
This reverts commit a7c47eb.
CI failed in 6ce9d18 on Dokka. This is a known issue, and we're waiting for the new version of Dokka.
|
@JorgeCastilloPrz @rachelcarmena @rachelcarmena @aballano The build & build integration were green for 3 commits in a row, with an increased iteration rate of 350 compared to 100 on |
We've been seeing some flakiness in the past 2-3 weeks.
It's been mostly stabilized, but not quite yet.
We seem to be seeing some flakiness due to stress-related increased CPU latency. This test suite runs fine on my machine and some of this flakiness is not reproducible locally.
Due to increased CPU latency, scheduling becomes less precise. This is especially noticeable in tests that use
sleep
,currentTimeMillis
ornanoTime
.We're also running all Gradle modules in parallel, which means that the test suite of Arrow Fx, Arrow. Fx Coroutines, Reactor & RxJava are all running at the same time.
Perhaps this is not ideal for test suites that uses concurrency in almost every test.
Therefore I think we need to see where we can rewrite flaky
sleep
orscheduling
tests to use latches instead ofsleep
. See #211 for such a fix.This PR is meant for discussion, so we can try and think of a battle plan to tackle this.
2 suggestions I think could help us try and pinpoint this: