Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ide plugin #801

Merged
merged 13 commits into from
Apr 19, 2021
Merged

remove ide plugin #801

merged 13 commits into from
Apr 19, 2021

Conversation

i-walker
Copy link
Member

No description provided.

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @i-walker and RIP IDE plugin for now 🙏 . Let's wait for @rachelcarmena before merging, and I think she is in the middle of adapting to 1.5. Thanks!

Copy link
Contributor

@danimontoya danimontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @i-walker ! Indeed RIP ide plugins!

Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-walker 🙌

Please, take a look at the changes I added:

  • Recovering artifacts publication
  • Removing shadow jar creation
  • Improving compiler plugin dependencies
  • Removing Arrow Meta IDE plugin installation from Gradle Plugin
  • Adding transitive deps from compiler plugin in the Gradle Plugin instead of explicit deps.
  • Removing the configuration of doc validation because there aren't compile deps from Intellij to add in runtime.
  • Update documentation (sidebar, setup, ...)
  • Other small configuration changes

Please, I think these files could be updated as well:

  • compiler-plugin/src/main/kotlin/arrow/meta/dsl/platform/Platform.kt
  • compiler-plugin/src/main/kotlin/arrow/meta/dsl/resolve/ResolveSyntax.kt
  • compiler-plugin/src/main/kotlin/arrow/meta/internal/registry/InternalRegistry.kt
  • compiler-plugin/src/main/kotlin/arrow/meta/internal/kastree/ast/psi/Parser.kt

and this file could be removed, right?

  • compiler-plugin/src/main/resources/META-INF/services/org.jetbrains.kotlin.diagnostics.rendering.DefaultErrorMessages$Extension

Thanks!!! 🙌

@@ -21,7 +21,6 @@ dependencies {
implementation "org.jetbrains.kotlin:kotlin-gradle-plugin-api:$KOTLIN_VERSION"
implementation "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION"
implementation "io.github.classgraph:classgraph:$CLASS_GRAPH_VERSION"
implementation "xerces:xercesImpl:$XERCES_VERSION"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question for what did we use this @rachelcarmena?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -40,21 +38,6 @@ class ArrowGradlePlugin : Plugin<Project> {
)
}
}
project.tasks.register("install-idea-plugin", InstallIdeaPlugin::class.java) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏾

@i-walker
Copy link
Member Author

Thanks a lot @rachelcarmena 🙌🏾 I am going to push some additional changes from what you suggested.

@i-walker
Copy link
Member Author

i-walker commented Apr 19, 2021

On some of the changes I haven't changed/ updated:

  • compiler-plugin/src/main/kotlin/arrow/meta/dsl/resolve/ResolveSyntax.kt
    IMO those are fine bc main still depends on the Descriptor API's in 1.4.10.
  • compiler-plugin/src/main/kotlin/arrow/meta/internal/registry/InternalRegistry.kt
    Haven't found something in InternalRegistry that would relate to the Ide.
  • compiler-plugin/src/main/kotlin/arrow/meta/dsl/platform/Platform.kt
    Here and all usages of the ide function are required, so the compiler plugin interacts well with the IDE base APIs for compiler plugins. Unless we want to remove this.
  • compiler-plugin/src/main/kotlin/arrow/meta/internal/kastree/ast/psi/Parser.kt
    So true, we haven't used this part of the Parser at all 😄
  • compiler-plugin/src/main/resources/META-INF/services/org.jetbrains.kotlin.diagnostics.rendering.DefaultErrorMessages$Extension
    This one is also needed so it registers our Diagnostics in the compiler. It existed in the Ide because that has a symmetric extension/ api.

Thanks for the feedback review @rachelcarmena , when I oversaw something let me know 🙌🏾

Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @i-walker !!! 🎉

@rachelcarmena rachelcarmena merged commit 12f6128 into main Apr 19, 2021
@rachelcarmena rachelcarmena deleted the rm-ide-plugin branch April 19, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants