-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ide plugin #801
remove ide plugin #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @i-walker and RIP IDE plugin for now 🙏 . Let's wait for @rachelcarmena before merging, and I think she is in the middle of adapting to 1.5. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @i-walker ! Indeed RIP ide plugins!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take a look at the changes I added:
- Recovering artifacts publication
- Removing shadow jar creation
- Improving compiler plugin dependencies
- Removing Arrow Meta IDE plugin installation from Gradle Plugin
- Adding transitive deps from compiler plugin in the Gradle Plugin instead of explicit deps.
- Removing the configuration of doc validation because there aren't compile deps from Intellij to add in runtime.
- Update documentation (sidebar, setup, ...)
- Other small configuration changes
Please, I think these files could be updated as well:
- compiler-plugin/src/main/kotlin/arrow/meta/dsl/platform/Platform.kt
- compiler-plugin/src/main/kotlin/arrow/meta/dsl/resolve/ResolveSyntax.kt
- compiler-plugin/src/main/kotlin/arrow/meta/internal/registry/InternalRegistry.kt
- compiler-plugin/src/main/kotlin/arrow/meta/internal/kastree/ast/psi/Parser.kt
and this file could be removed, right?
- compiler-plugin/src/main/resources/META-INF/services/org.jetbrains.kotlin.diagnostics.rendering.DefaultErrorMessages$Extension
Thanks!!! 🙌
@@ -21,7 +21,6 @@ dependencies { | |||
implementation "org.jetbrains.kotlin:kotlin-gradle-plugin-api:$KOTLIN_VERSION" | |||
implementation "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION" | |||
implementation "io.github.classgraph:classgraph:$CLASS_GRAPH_VERSION" | |||
implementation "xerces:xercesImpl:$XERCES_VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question for what did we use this @rachelcarmena?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To parse the XML file of the private IDEA plugins repository: https://github.com/arrow-kt/arrow-meta/blob/main/gradle-plugin/src/main/kotlin/arrow/meta/plugin/gradle/InstallIdeaPlugin.kt#L50
@@ -40,21 +38,6 @@ class ArrowGradlePlugin : Plugin<Project> { | |||
) | |||
} | |||
} | |||
project.tasks.register("install-idea-plugin", InstallIdeaPlugin::class.java) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏾
Thanks a lot @rachelcarmena 🙌🏾 I am going to push some additional changes from what you suggested. |
On some of the changes I haven't changed/ updated:
Thanks for the feedback review @rachelcarmena , when I oversaw something let me know 🙌🏾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @i-walker !!! 🎉
No description provided.