This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Deprecate extension methods for List and ListK #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
approved these changes
Jan 11, 2021
raulraja
reviewed
Jan 12, 2021
franciscodr
commented
Jan 12, 2021
| @Deprecated( | ||
| "ListK is being deprecated, use the function defined for List instead.", | ||
| ReplaceWith("List::class.head<A>()"), | ||
| DeprecationLevel.WARNING) |
There was a problem hiding this comment.
This are issues we'll only encounter in Optics afaik and it's unrelated to the typeclasses. We have the same issue in all other types, for example TupleN since these are just top-level APIs for Optics. Similar to emptyList<A>() and listOf(1, 2, 3) etc in Kotlin.
So we can either follow the Kotlin Std pattern of putting this simply as top-level functions, or we follow Paco's suggestion of Optional.listHead<A>() which I like better to be honest.
There was a problem hiding this comment.
Optional companion option sounds good 👍
franciscodr
commented
Jan 12, 2021
| /** | ||
| * [PIso] that defines equality between a [List] and [Option] [NonEmptyList] | ||
| */ | ||
| fun <A, B> KClass<List<*>>.toPOptionNel(): PIso<List<A>, List<B>, Option<NonEmptyList<A>>, Option<NonEmptyList<B>>> = |
There was a problem hiding this comment.
Same here. It could be created as PIso.listToPOptionNel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.