Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal scrolling for home page on mobile #150

Closed
ianbrandt opened this issue Apr 4, 2023 · 1 comment · Fixed by #152
Closed

Horizontal scrolling for home page on mobile #150

ianbrandt opened this issue Apr 4, 2023 · 1 comment · Fixed by #152
Assignees
@calvellido

Comments

@ianbrandt
Copy link

ianbrandt commented Apr 4, 2023 •
edited
Loading

https://arrow-kt.io

image
@ianbrandt
Copy link
Author

From a responsive page layout standpoint, the blocks and quotes on the home page would probably be better as single-column at mobile widths, though maybe the current two-column layout is a side effect of the overflow issue above. Let me know if you want me to file this as a separate issue.

image

@calvellido calvellido self-assigned this Apr 4, 2023
@calvellido calvellido mentioned this issue Apr 4, 2023
Merged
calvellido added a commit that referenced this issue Apr 4, 2023
@calvellido
Improve page layouts for responsive (#152)
a113bc7 
### Description:

This PR makes some adjustments to all views on site pages to improve
their layouts on smaller devices like tablets and mobile. There's still
some pending work to do, as the build step of the site is messing some
styles (I need to check a bit on the webpack plugins minimizing stuff
and such to find the culprit). It also changes a bit the way the
`StarsCount` component was being shown to use an SVG icon instead of the
star ⭐ emoji.

It also removes some unused code that was there commented or directly
unused.

This fixes #150. 


### Preview:


![imagen](https://user-images.githubusercontent.com/7753447/229835275-29917a97-1ec8-4c59-84fa-d674fec9d2c3.png)


![imagen](https://user-images.githubusercontent.com/7753447/229835541-8b7d6f5e-42f0-4ce0-8f76-46bc5d07fa62.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvellido calvellido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve page layouts for responsive arrow-kt/arrow-website
2 participants
@ianbrandt @calvellido