Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page layouts for responsive #152

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

calvellido
Copy link
Member

@calvellido calvellido commented Apr 4, 2023

Description:

This PR makes some adjustments to all views on site pages to improve their layouts on smaller devices like tablets and mobile. There's still some pending work to do, as the build step of the site is messing some styles (I need to check a bit on the webpack plugins minimizing stuff and such to find the culprit). It also changes a bit the way the StarsCount component was being shown to use an SVG icon instead of the star ⭐ emoji.

It also removes some unused code that was there commented or directly unused.

This fixes #150.

Preview:

imagen

imagen

Copy link
Contributor

@gutiory gutiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @calvellido! Thanks!

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Amazing work @calvellido 🙌

@calvellido calvellido merged commit a113bc7 into main Apr 4, 2023
@calvellido calvellido deleted the calvellido-responsive-fixes branch April 4, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scrolling for home page on mobile
3 participants