Write nullable vs option document #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
reviewed
Feb 23, 2023
nomisRev
requested review from
franciscodr,
gutiory,
i-walker,
raulraja,
realdavidvega,
serras and
misabelcarde
nomisRev
commented
Feb 23, 2023
Comment on lines
+38
to
+48
| listOf(null, 2, 3).firstOrElse { -1 } shouldBe null | ||
| } | ||
| ``` | ||
| <!--- KNIT example-option-02.kt --> | ||
| <!--- TEST lines.first().startsWith("Exception in thread \"main\" java.lang.AssertionError: Expected null but actual was -1") --> | ||
|
|
||
| Now we're executing the function on a list that `isNotEmpty`, so we expect it to return the first element of value `null`. | ||
| Instead however it returns `-1`, which is the default value we specified in case the list `isEmpty`! | ||
|
|
||
| ``` | ||
| Exception in thread "main" java.lang.AssertionError: Expected null but actual was -1 |
There was a problem hiding this comment.
I felt it was super hard to find a good example of nested nullability problem 😅
Happy I found one, even though it can be fixed with if(isEmpty()) 😓
Any suggestions on any of the examples, or content is very welcome 🙏
|
This is pretty cool stuff! |
franciscodr
reviewed
Feb 24, 2023
Co-authored-by: David Vega Lichacz <7826728+realdavidvega@users.noreply.github.com> Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
|
Thank you @franciscodr & @realdavidvega! Great suggestions 🙏 |
serras
reviewed
Feb 24, 2023
serras
reviewed
Feb 24, 2023
Co-authored-by: Alejandro Serrano <trupill@gmail.com>
|
Merging this, all feedback or suggestions are still welcome of course |
i-walker
added a commit
that referenced
this pull request
Feb 28, 2023
nomisRev
pushed a commit
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating original
Optiondocumentation, and including a section on why Arrow hasOption.