Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Wrapper class for SortedMap #205

Closed
Atternatt opened this issue Aug 14, 2017 · 9 comments
Closed

Create Wrapper class for SortedMap #205

Atternatt opened this issue Aug 14, 2017 · 9 comments
Labels
beginner friendly enhancement help wanted

Comments

@Atternatt
Copy link
Collaborator

No description provided.

@krishnarb3
Copy link

Hello, I would like to take this up. Can you explain what exactly is to be done, I am new to this project.

@pakoito
Copy link
Member

pakoito commented Oct 20, 2017

Hi @krishnarb3! Sure, the PR will be quite similar to the wrapper for regular maps. @victorg1991 completed that some weeks ago, so you can take a look at his job: https://github.com/kategory/kategory/pull/310/files

@victorg1991
Copy link
Contributor

@krishnarb3 If you have any question about it I'll be happy to answer it :D

@krishnarb3
Copy link

Thanks both of you, I'm going through the operator and the PR. Will definitely ask you once I'm done 😁 @victorg1991

@krishnarb3
Copy link

Also do we have an irc/slack channel/mailing list for kategory?

@pakoito
Copy link
Member

pakoito commented Oct 20, 2017

Yes, try https://gitter.im/kategory/Lobby!

@Cotel
Copy link
Member

Cotel commented Nov 6, 2017

@krishnarb3 Are you still working on this Issue? I would like to take it if you dont mind 😄

@Cotel Cotel mentioned this issue Nov 7, 2017
Merged
@krishnarb3
Copy link

Sorry for the late response, i wasn't online for a while.
Also amazing work on the PR, I'll look into some other issue that I can contribute to.
Cheers :D

@pakoito
Copy link
Member

pakoito commented Feb 8, 2018

Completed by #451 . Thanks @Cotel !!!

@pakoito pakoito closed this as completed Feb 8, 2018
rachelcarmena pushed a commit that referenced this issue Feb 24, 2021
@pablisco
Add Semigroup and deconstruction to Ior (#205)
151ed0b 
* Initial naive implementation

* Removed monoid laws and added individual test cases

* Cleaned up ior and removed unecessary changes

* Add destructuring tests

* fixed formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pakoito @Atternatt @Cotel @krishnarb3 @victorg1991