Fix Foldable foldMapM restrictions #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianRaFo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
============================================
- Coverage 39.97% 39.96% -0.01%
Complexity 711 711
============================================
Files 356 356
Lines 9977 9978 +1
Branches 1046 1046
============================================
Hits 3988 3988
- Misses 5690 5691 +1
Partials 299 299
Continue to review full report at Codecov.
|
pakoito
reviewed
Oct 21, 2018
| where TC : Monad<G>, TC : Monoid<B> = tc.run { | ||
| foldM(tc, tc.empty()) { b, a -> f(a).map { b.combine(it) } } | ||
| fun <G, A, B, MA, MO> Kind<F, A>.foldMapM(ma: MA, mo: MO, f: (A) -> Kind<G, B>): Kind<G, B> | ||
| where MA : Monad<G>, MO : Monoid<B> = ma.run { |
There was a problem hiding this comment.
This will crash Android builds with the new compiler. You cannot nest two run directly.
There was a problem hiding this comment.
Fixed here #1058
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were applying the Monad and Monoid restrictions to the same type
TC.This PR and the monoid parameter separately solving that.