Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix documentation link (https://github.com/arrow-kt/arrow/issues/1216) #1217

Merged
merged 3 commits into from
Dec 21, 2018
Merged

fix documentation link (https://github.com/arrow-kt/arrow/issues/1216) #1217

merged 3 commits into from
Dec 21, 2018

Conversation

plastic-karma
Copy link
Contributor

Pull request to fix broken documentation link #1216

Tested by running

./gradlew clean dokka :arrow-docs:runAnk
cd modules/docs/arrow-docs/
bundle exec jekyll serve --source build/site/

and testing links in https://arrow-kt.io/docs/optics/each/ and https://arrow-kt.io/docs/arrow/data/nonemptylist/

pakoito
pakoito approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Thanks for sorting this out so quickly :D

@raulraja raulraja merged commit 89163d0 into arrow-kt:master Dec 21, 2018
@plastic-karma plastic-karma deleted the fix_issue_1216 branch December 22, 2018 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@pakoito pakoito pakoito approved these changes

@nomisRev nomisRev nomisRev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plastic-karma @raulraja @pakoito @nomisRev