Updated Gradle and some dependencies including Kotlin #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
reviewed
Mar 9, 2019
| kotlinxCoroutinesVersion = '1.1.1' | ||
| projectReactorVersion = '3.2.6.RELEASE' | ||
| retrofitVersion = '2.5.0' | ||
| rxJavaVersion = '2.2.7' |
pakoito
approved these changes
Mar 9, 2019
jrgonzalezg
force-pushed
the
jrgonzalezg-update-gradle-and-some-dependencies
branch
2 times, most recently
from
30c3467
to
6e0d975
Compare
raulraja
approved these changes
Mar 9, 2019
jrgonzalezg
force-pushed
the
jrgonzalezg-update-gradle-and-some-dependencies
branch
3 times, most recently
from
92a3f0c
to
ce3f71c
Compare
|
Update of Gradle seems to be blocked by https://github.com/Takhion/kotlin-metadata__kotlin-compiler-lite bringing dependencies from 1.2.40 into the build which conflict with the version of Kotlin included on recent Gradle versions. May improve if a new version is merged including this: Takhion/kotlin-metadata__kotlin-compiler-lite#1 although that is still on 1.3.11 and not 1.3.21. |
jrgonzalezg
force-pushed
the
jrgonzalezg-update-gradle-and-some-dependencies
branch
5 times, most recently
from
fe46cb5
to
5305c47
Compare
pakoito
approved these changes
Mar 12, 2019
…ding Kotlin. Tweaked some gradle files to change where kapt plugin is applied to make it possible to use them with latest stable Kotlin version.
…tadata's compiler using a conflicting version of Kotlin
jrgonzalezg
force-pushed
the
jrgonzalezg-update-gradle-and-some-dependencies
branch
from
5305c47
to
b51ca53
Compare
jrgonzalezg
force-pushed
the
jrgonzalezg-update-gradle-and-some-dependencies
branch
from
b51ca53
to
5cfea75
Compare
…a custom outputFormatter is used so it needed additional setup to print the report. This may be improved later by hooking to the resolution strategy instead of the outputFormatter for what we are doing.
…ng properly with None / Some with latest Kotlin 1.3.21 but works on 1.3.11.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle wrapperupdates it to the version configured in the task on the mainbuild.gradlefile).build.gradlefiles cause thekaptplugin was applied too late causing the builds to fail with latest stable Kotlin.