Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource data type #1376

Merged
merged 13 commits into from
Mar 30, 2019
Merged

Resource data type #1376

merged 13 commits into from
Mar 30, 2019

Conversation

1Jajen1
Copy link
Member

@1Jajen1 1Jajen1 commented Mar 24, 2019

I got a bit side-tracked while writing and converting tests...

Solves #795.

Docs and kdoc is unfinished (kdoc is non-existant atm 😅), will finish that tomorrow.

@1Jajen1 1Jajen1 changed the title ManagedT data-type ManagedT datatype Mar 24, 2019
@pakoito
Copy link
Member

pakoito commented Mar 24, 2019

So far so good for me :D

@raulraja

This comment has been minimized.

@raulraja

This comment has been minimized.

@raulraja raulraja changed the title ManagedT datatype Resource data type Mar 25, 2019
@@ -15,7 +15,6 @@ import arrow.typeclasses.Semigroup
* When a resource is created one can make use of [invoke] to run a computation with the resource. The finalizers are then
* guaranteed to run afterwards in reverse order of acquisition.
**/
@documented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't this be documented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk I am not familiar enough with those annotations. The build failed because of it tho.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least that is what I read from the error

@@ -0,0 +1,127 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all should be in the kdocs, we no longer create markdown files for data types or type classes

@raulraja
Copy link
Member

FTR we discussed in slack this is useful as a data type

@1Jajen1 1Jajen1 marked this pull request as ready for review March 26, 2019 13:50
@1Jajen1
Copy link
Member Author

1Jajen1 commented Mar 28, 2019

I think this should be done :) I moved the docs to kdoc only and linked the api-docs in the menu.

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

*
* //sampleStart
* val program = fx {
* val consumer = createConsumer().bind()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ! instead of bind() that is the preferred way in fx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. That only goes for fx blocks right? I left the resource binding as is for now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and something I forgot: Don't ank:playground snippets require all code despite actually compiling with just the important bits? If so I need to add some stuff before merge :/

@1Jajen1 1Jajen1 merged commit 5a47692 into arrow-kt:master Mar 30, 2019
@1Jajen1 1Jajen1 mentioned this pull request Mar 30, 2019
@raulraja raulraja mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants