-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource
data type
#1376
Resource
data type
#1376
Conversation
So far so good for me :D |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -15,7 +15,6 @@ import arrow.typeclasses.Semigroup | |||
* When a resource is created one can make use of [invoke] to run a computation with the resource. The finalizers are then | |||
* guaranteed to run afterwards in reverse order of acquisition. | |||
**/ | |||
@documented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't this be documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk I am not familiar enough with those annotations. The build failed because of it tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least that is what I read from the error
@@ -0,0 +1,127 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all should be in the kdocs, we no longer create markdown files for data types or type classes
FTR we discussed in slack this is useful as a data type |
I think this should be done :) I moved the docs to kdoc only and linked the api-docs in the menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
* | ||
* //sampleStart | ||
* val program = fx { | ||
* val consumer = createConsumer().bind() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use ! instead of bind() that is the preferred way in fx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. That only goes for fx
blocks right? I left the resource binding as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and something I forgot: Don't ank:playground snippets require all code despite actually compiling with just the important bits? If so I need to add some stuff before merge :/
I got a bit side-tracked while writing and converting tests...
Solves #795.
Docs and kdoc is unfinished (kdoc is non-existant atm 😅), will finish that tomorrow.